Try/hint of more blocks in inserter #19609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquesanchez
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta,
talldan and
youknowriad
as code owners
youknowriad
added
[Feature] Inserter
|
@enriquesanchez I was just testing this PR and I wonder if you could go a little further and show all of the accordion? For me, not showing it all felt a little disjointed. |
|
thanks for the feedback @karmatosed! I updated the PR and added more height to the inserter, it should now look like this:
|
|
@enriquesanchez I am unsure of my dev env lately but for me on this branch, unline master I cannot open the block inserter on mobile:
|
|
Thanks for the feedback @karmatosed and @draganescu 🙏 Given that this is a tiny change and there's already other issues (#19836 and #17335) addressing changes to the block library, I'm going to go ahead and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #17872.
This PR explores setting
line-height: 1;to some button elements in the block inserter and adding10pxto the inserter's overall height in order to reveal more of the available blocks and categories, thus hinting to users that there's more content to scroll.How has this been tested?
Locally in MacOS Firefox, Safari and Chrome.
Screenshots
Before the change:
After the change:
Types of changes
CSS, visual.